Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify material and light parameters #112

Open
joaander opened this issue May 8, 2020 · 1 comment
Open

Clarify material and light parameters #112

joaander opened this issue May 8, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request essential Work that must be completed
Milestone

Comments

@joaander
Copy link
Member

joaander commented May 8, 2020

Description

Some of the material and light parameters would be more clear with appropriate names.

  • Light.color should be intensity
  • Material.color should be albedo
  • Material.solid should be emit and an RGB. emit=(0,0,0) will be equivalent to solid=0 and a non-zero emit will be equivalent to solid=1, color=emit.
@joaander joaander added the enhancement New feature or request label May 8, 2020
@joaander joaander added this to the 0.13.0 milestone May 8, 2020
@joaander joaander self-assigned this May 8, 2020
@joaander joaander modified the milestones: 0.13.0, 0.14.0 Nov 13, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jul 31, 2021
@joaander joaander added the essential Work that must be completed label Aug 2, 2021
@github-actions github-actions bot removed the stale label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request essential Work that must be completed
Projects
None yet
Development

No branches or pull requests

1 participant