Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why a.m. but the other is A.M.? #976

Closed
aclueless opened this issue Oct 2, 2023 · 2 comments · Fixed by #1014
Closed

Why a.m. but the other is A.M.? #976

aclueless opened this issue Oct 2, 2023 · 2 comments · Fixed by #1014
Milestone

Comments

@aclueless
Copy link

Affected synsets

https://en-word.net/lemma/a.m. (Adjective)
https://en-word.net/lemma/A.M. (Adverb)

and similarly:

https://en-word.net/lemma/p.m. (Adjective)
https://en-word.net/lemma/P.M. (Adverb)

Proposed changes
I think these items should include alternative forms found in wiktionary.org (links below).

Also, wiktionary.org only has adverbs for these items. This is just a note, I am not an English speaker to say anything about this.

Motivation
https://en.wiktionary.org/wiki/a.m.#English
https://en.wiktionary.org/wiki/p.m.#English

@jmccrae jmccrae added this to the 2024 Release milestone Oct 2, 2023
@jmccrae
Copy link
Member

jmccrae commented Oct 2, 2023

Yes, I don't think these should be adjectives, they can however be nouns (e.g., "in the a.m.")

We should also make sure that we have all variant (A.M., a.m., AM, am) in the synset.

@jmccrae
Copy link
Member

jmccrae commented Oct 2, 2023

I also note that the noun senses were identified as missing in #956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants