Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overcomplicated UniformsStorage? #1930

Open
julhe opened this issue May 22, 2021 · 0 comments
Open

Overcomplicated UniformsStorage? #1930

julhe opened this issue May 22, 2021 · 0 comments

Comments

@julhe
Copy link

julhe commented May 22, 2021

While trying to put a UniformStorage into an enum (and failing due to UniformStorage not beeing "object safe") , I discoverd it was easier to just write my own abstraction like

#[derive(Default)]
struct UniformVec<'a, 'b>{
    pub uniforms: Vec<(&'a str, UniformValue<'b>)>
}

impl Uniforms for UniformVec<'_, '_>{
    fn visit_values<'a, F: FnMut(&str, UniformValue<'a>)> (&'a self, mut func: F) {
        for uniform in &self.uniforms{
            func(uniform.0, uniform.1);
        }
    }
}

Forgive me the maybe naive question, but why is UniformStorage implemented as a chain of FnMut instead of an simple Vec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant