Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix Signature integration for external consumers #393

Merged
merged 3 commits into from Apr 8, 2022

Conversation

dfreeman
Copy link
Contributor

@dfreeman dfreeman commented Apr 8, 2022

This backports #392 to v1.x.

The only notable difference is that because of the way types tests on the 1.x branch use paths to locate the published packages in dist, the type mapping has to exist both in the tests' tsconfig.json and in @glint/component's package.json.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thank you!

@chriskrycho chriskrycho merged commit 824dcfb into glimmerjs:v1.x Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants