Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo: add tests around component destruction #382

Open
NullVoxPopuli opened this issue Feb 24, 2022 · 0 comments
Open

Todo: add tests around component destruction #382

NullVoxPopuli opened this issue Feb 24, 2022 · 0 comments

Comments

@NullVoxPopuli
Copy link
Contributor

Discovered in: #379 (comment)

We found that we could migrate to @ember/destroyable in @glimmer/component's ember-component-manager without failure in ember-source < 3.22 -- this is problematic because @ember/destroyable doesn't exist in older embers -- so it means we are missing important test coverage around destruction.

PRs and help welcome <3
@NullVoxPopuli NullVoxPopuli mentioned this issue Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NullVoxPopuli