Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@glimmer/component uses private API for destroyables #319

Open
pzuraq opened this issue Dec 5, 2020 · 0 comments
Open

@glimmer/component uses private API for destroyables #319

pzuraq opened this issue Dec 5, 2020 · 0 comments

Comments

@pzuraq
Copy link
Member

pzuraq commented Dec 5, 2020

@glimmer/component currently uses private API for destroyables: https://github.com/glimmerjs/glimmer.js/blob/v1.0.2/packages/%40glimmer/component/addon/-private/ember-component-manager.ts#L40-L61

This currently requires us to re-export the values from @glimmer/runtime even though they now are defined in @glimmer/destroyable. We should try to fix this, potentially for the v2 release.

pzuraq pushed a commit to glimmerjs/glimmer-vm that referenced this issue Dec 5, 2020
Fixes @glimmer/component, see glimmerjs/glimmer.js#319
for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant