Remove deprecated Modifier Manager version 3.13 #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
reviewed
Sep 10, 2021
|
|
||
| // This capability is used in Ember, exclusively in resolution mode. See the | ||
| // Ember glimmer resolver for details. | ||
| passFactoryToCreate: managerAPI === '3.13', | ||
| passFactoryToCreate: false, |
There was a problem hiding this comment.
That this and line 46 above are now hard-coded likely points to further possible removals.
There was a problem hiding this comment.
Good call, fixed in #1334
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Sep 27, 2021
High level breaking changes: * `@glimmer/integration-tests`, `@glimmer/manager`, `@glimmer/validator` * [#1330](glimmerjs/glimmer-vm#1330) Remove deprecated support for mutation after consumption during certain manager hooks ([@snewcomer](https://github.com/snewcomer)) * `@glimmer/manager` * [#1328](glimmerjs/glimmer-vm#1328) Remove deprecated Component Manager version 3.4 ([@nlfurniss](https://github.com/nlfurniss)) * `@glimmer/integration-tests`, `@glimmer/manager` * [#1329](glimmerjs/glimmer-vm#1329) Remove deprecated Modifier Manager version 3.13 ([@nlfurniss](https://github.com/nlfurniss)) See full details here: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.81.0
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Sep 29, 2021
High level breaking changes: * `@glimmer/integration-tests`, `@glimmer/manager`, `@glimmer/validator` * [#1330](glimmerjs/glimmer-vm#1330) Remove deprecated support for mutation after consumption during certain manager hooks ([@snewcomer](https://github.com/snewcomer)) * `@glimmer/manager` * [#1328](glimmerjs/glimmer-vm#1328) Remove deprecated Component Manager version 3.4 ([@nlfurniss](https://github.com/nlfurniss)) * `@glimmer/integration-tests`, `@glimmer/manager` * [#1329](glimmerjs/glimmer-vm#1329) Remove deprecated Modifier Manager version 3.13 ([@nlfurniss](https://github.com/nlfurniss)) See full details here: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.81.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the deprecation guide, support for 3.13 is removed in Ember 4.0