Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's land the ErrorRecovery work #1526

Open
6 tasks done
NullVoxPopuli opened this issue Dec 11, 2023 · 0 comments
Open
6 tasks done

Let's land the ErrorRecovery work #1526

NullVoxPopuli opened this issue Dec 11, 2023 · 0 comments

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Dec 11, 2023

Steps:

Results:

Left to right:

  • ember-source 5.7 (canary)
  • ember-source 5.7 (canary + glimmer-vm's main branch)
  • ember-source 5.7 (canary + glimmer-vm's error-recovery branch)

image

image

2323-12-12

ember-source is the same between both runs, (main)
only difference is glimmer-vm published vs main
still feels like margin of error though.
would need to compare with other folks' machines.

image

2023-12-11

NOTE: I need to use the same ember-source for both of these to reduce variables.
This bench had two variables:

  • super old glimmer-vm vs glimmer-vm @ main
  • ember-source 5.3 vs 5.6
  • the current glimmer-vm on ember-source is much newer

ember-source 5.3 with glimmer-vm 0.84.2
vs
ember-source 5.6-alpha with glimmer-vm @ main

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant