Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation to assert with helpful error #1363

Open
mixonic opened this issue Nov 14, 2021 · 0 comments
Open

Update deprecation to assert with helpful error #1363

mixonic opened this issue Nov 14, 2021 · 0 comments

Comments

@mixonic
Copy link
Member

mixonic commented Nov 14, 2021

GlimmerVM has a codepath to issue deprecations for when an argument-less helper is passed with no arguments:

id: 'argument-less-helper-paren-less-invocation',

In Ember loose mode templates this syntax results in an invocation, however the behavior was deprecated in Ember 3.x https://deprecations.emberjs.com/v3.x/#toc_argument-less-helper-paren-less-invocation and has been changed to a throw in Ember 4.0 emberjs/ember.js#19843.

Here in GlimmerVM the deprecation should be converted to a dev-time assertion. This would allow for a better error message than the one throws in Ember as of this writing. The prod-mode behavior for this syntax may also change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant