[REFACTOR] Moves UpdatableRootReference to integration tests #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves UpdatableRootReference to integration tests, which is where it is primarily used, and creates alternative references for usage in other tests. Also removes the "autotracking" tests from the `@glimmer/reference` package, since those don't really match up with reality anymore, and their test scenarios are covered by other tests in the `@glimmer/validator` package.
pzuraq
force-pushed
the
refactor/move-updatable-root-reference
branch
from
46cbc1b
to
c2a4b20
Compare
rwjblue
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves UpdatableRootReference to integration tests, which is where it is
primarily used, and creates alternative references for usage in other
tests. Also removes the "autotracking" tests from the
@glimmer/referencepackage, since those don't really match up withreality anymore, and their test scenarios are covered by other tests in
the
@glimmer/validatorpackage.Depends on #1059