Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal modes #98

Open
shazow opened this issue Mar 23, 2019 · 3 comments · Fixed by charmbracelet/ssh#5 · May be fixed by #210
Open

Terminal modes #98

shazow opened this issue Mar 23, 2019 · 3 comments · Fixed by charmbracelet/ssh#5 · May be fixed by #210
Labels
question

Comments

@shazow
Copy link
Member

shazow commented Mar 23, 2019

There's a line here that mentions terminal modes:

ssh/ssh.go

Line 77 in e5ece14

// HELP WANTED: terminal modes!

What do we envision for "terminal modes"?
@belak
Copy link
Collaborator

belak commented Jun 12, 2019 •
edited

Ooh boy, this is a rabbit hole if I've ever seen one.

https://tools.ietf.org/html/rfc4254#section-8 provides more information on these.

I believe supporting these would require deeper integration with the pty, as this implements quite a few operations on the pty.

@belak
Copy link
Collaborator

belak commented Jun 19, 2019

In particular, it looks like this would involve implementing a basic terminal inside this package - looks like our hacky attempt at working around this is causing issues for subsystem support in #103

@progrium
Copy link
Contributor

Terminal stuff is nutso. Hopefully there is something implementing out there we can just use here.

This was referenced Jul 31, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
3 participants
@progrium @shazow @belak