Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return ssh.Context #168

Merged
merged 1 commit into from May 9, 2022
Merged

feat: return ssh.Context #168

merged 1 commit into from May 9, 2022

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Jan 6, 2022

changes ssh.Session interface to return ssh.Context instead of context.Context.

This allows users to do things like session.Context().SetValue(foo, bar).

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@belak
Copy link
Collaborator

belak commented May 9, 2022

This should be alright since it's just widening the return type and should work everywhere context.Context already does. Thanks!

@belak belak merged commit 777ab34 into gliderlabs:master May 9, 2022
@caarlos0 caarlos0 deleted the ctx branch May 9, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants