Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use internal instead of not external #541

Merged
merged 4 commits into from Nov 17, 2019
Merged

refactor: use internal instead of not external #541

merged 4 commits into from Nov 17, 2019

Conversation

Graborg
Copy link
Contributor

@Graborg Graborg commented Oct 3, 2019

Based on #539

Change from !remote? -> internal? and handle all the domino effects of this.

@Graborg Graborg requested a review from Floppy as a code owner October 3, 2019 11:10
@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

Merging #541 into master will decrease coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #541     +/-   ##
=========================================
- Coverage   98.61%   98.41%   -0.2%     
=========================================
  Files          30       30             
  Lines        1943     1956     +13     
=========================================
+ Hits         1916     1925      +9     
- Misses         27       31      +4
Impacted Files Coverage Δ
spec/html-proofer/links_spec.rb 99.28% <100%> (+0.01%) ⬆️
lib/html-proofer/element.rb 99.21% <100%> (+1.65%) ⬆️
lib/html-proofer/check/links.rb 91.56% <100%> (-7.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63663a4...182661d. Read the comment docs.

@gjtorikian
Copy link
Owner

Thanks!

@gjtorikian gjtorikian merged commit de5d878 into gjtorikian:master Nov 17, 2019
@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f759f90). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #541   +/-   ##
=========================================
  Coverage          ?   98.45%           
=========================================
  Files             ?       30           
  Lines             ?     1946           
  Branches          ?        0           
=========================================
  Hits              ?     1916           
  Misses            ?       30           
  Partials          ?        0
Impacted Files Coverage Δ
lib/html-proofer/utils.rb 100% <100%> (ø)
spec/html-proofer/links_spec.rb 99.29% <100%> (ø)
lib/html-proofer/check/links.rb 92.68% <100%> (ø)
lib/html-proofer/middleware.rb 96.55% <100%> (ø)
lib/html-proofer/element.rb 98.46% <100%> (ø)
spec/html-proofer/utils_spec.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f759f90...165b013. Read the comment docs.

@Graborg Graborg deleted the refactor/use-internal-instead-of-not-external branch November 27, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants