Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitleaksignore file fingerprint issue after pull request squash and merge #1355

Open
Rajalakshmiselvaraj-alation opened this issue Feb 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Rajalakshmiselvaraj-alation
Copy link

Scenario:
Once a false positive secret is detected in a pull request, the fingerprint is added to the .gitleaksignore file. This fingerprint references a PR commit.
The pull request is then merged to main branch with **squash and merge** option. Now the PR commit information is lost and the information in .gitleaksignore file becomes stale.

When gitleaks is run on main branch, the leaks are reported again as the commit information in .gitleaksignore file is diiferent.

Additional context
https://github.com/gitleaks/gitleaks/actions/runs/5259249899
The same issue has happened in this repository as well.

cc @zricethezav

@Rajalakshmiselvaraj-alation Rajalakshmiselvaraj-alation added the enhancement New feature or request label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant