From 9114b0c34dd87ab2266ebe4b4a4a988a2fa2bbc4 Mon Sep 17 00:00:00 2001 From: Yunlei Liu Date: Fri, 17 Apr 2020 22:58:56 -0700 Subject: [PATCH 1/5] The Layout/Tab cop has been renamed to Layout/IndentationStyle https://github.com/rubocop-hq/rubocop/pull/7867 --- config/_default_shared.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/config/_default_shared.yml b/config/_default_shared.yml index 5f6b42a..deea959 100644 --- a/config/_default_shared.yml +++ b/config/_default_shared.yml @@ -26,6 +26,9 @@ Layout/EndAlignment: Layout/EndOfLine: Enabled: true +Layout/IndentationStyle: + Enabled: true + Layout/InitialIndentation: Enabled: true @@ -72,9 +75,6 @@ Layout/SpaceInsideRangeLiteral: Layout/SpaceInsideReferenceBrackets: Enabled: true -Layout/Tab: - Enabled: true - Layout/TrailingEmptyLines: Enabled: true From ec4f74748f46f9cbc0a9f772f80ca518d73df61d Mon Sep 17 00:00:00 2001 From: Yunlei Liu Date: Fri, 17 Apr 2020 23:00:08 -0700 Subject: [PATCH 2/5] remove dup redundant Lint/EndInMethod cop https://github.com/rubocop-hq/rubocop/issues/7813 --- config/_default_shared.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/config/_default_shared.yml b/config/_default_shared.yml index deea959..a40e0d8 100644 --- a/config/_default_shared.yml +++ b/config/_default_shared.yml @@ -108,9 +108,6 @@ Lint/EmptyEnsure: Lint/EmptyInterpolation: Enabled: true -Lint/EndInMethod: - Enabled: true - Lint/EnsureReturn: Enabled: true From 8a08e8ee2bdac566a81549c8313e0b2ac870321f Mon Sep 17 00:00:00 2001 From: Yunlei Liu Date: Fri, 17 Apr 2020 23:10:44 -0700 Subject: [PATCH 3/5] Move LineLength cop from Metrics department to Layout department https://github.com/rubocop-hq/rubocop/pull/7542 --- config/_default_shared.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/config/_default_shared.yml b/config/_default_shared.yml index a40e0d8..d20e7b6 100644 --- a/config/_default_shared.yml +++ b/config/_default_shared.yml @@ -32,6 +32,9 @@ Layout/IndentationStyle: Layout/InitialIndentation: Enabled: true +Layout/LineLength: + Enabled: false + Layout/SpaceAfterColon: Enabled: true @@ -180,9 +183,6 @@ Metrics/ClassLength: Metrics/CyclomaticComplexity: Enabled: false -Metrics/LineLength: - Enabled: false - Metrics/MethodLength: Enabled: false From acb12ac7e5fad23a72894cbd902dbe7776836251 Mon Sep 17 00:00:00 2001 From: Yunlei Liu Date: Fri, 17 Apr 2020 23:26:52 -0700 Subject: [PATCH 4/5] add rubocop-performance The .rubocop.yml for rubocop-github itself is: `inherit_from: ./config/default.yml`, which `inherit_from: default_deprecated.yml`, which `inherit_from: _default_shared.yml`, which is using some Performance cop there. --- .rubocop.yml | 3 +++ Gemfile | 2 ++ 2 files changed, 5 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 802a6e6..2e32511 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,8 @@ inherit_from: ./config/default.yml +require: + - rubocop-performance + Naming/FileName: Enabled: true Exclude: diff --git a/Gemfile b/Gemfile index bb94df8..8093046 100644 --- a/Gemfile +++ b/Gemfile @@ -2,3 +2,5 @@ source "https://rubygems.org" gemspec + +gem "rubocop-performance", require: false From 724e240db2bb76ef0b6c18301a78f4c915acaab9 Mon Sep 17 00:00:00 2001 From: Yunlei Liu Date: Fri, 17 Apr 2020 23:34:26 -0700 Subject: [PATCH 5/5] remove 2.3 and add 2.7 in ruby test matrix https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/ --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 9497859..b224c41 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,7 +6,7 @@ git: depth: 10 rvm: - - 2.3.8 - 2.4.6 - 2.5.5 - 2.6.3 + - 2.7.1