Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding webrick to the whitelist of allowed GitHub Pages dependencies to avoid build warnings #887

Open
daattali opened this issue Aug 8, 2023 · 1 comment

Comments

@daattali
Copy link

daattali commented Aug 8, 2023

There are a few issues regarding updating the documentation around webrick not being available in Ruby 3, but this issue is about a different problem.

If I want to support local builds, I must manually add webrick to the Gemfile. However, because of a recent change in jekyll-build-pages, this now results in a warning "github-pages can't satisfy your Gemfile's dependencies" for every build. This means that anyone who wants to host a GitHub Pages repo that uses the default jekyll builder, and also wants to be able to run locally, will always have to see a warning on every GitHub Actions build.

I don't know the security implications of allowing webrick in GitHub Pages, but I hope it can be done. If not, perhaps we should be able to remove that warning message somehow.

@ohadschn
Copy link

ohadschn commented Oct 20, 2023

I believe there is a simple workaround, in your Gemfile:

install_if -> { ENV["GITHUB_ACTIONS"] != "true" } do
    puts "Is GitHub action: #{ENV["GITHUB_ACTIONS"] == "true"}"
    gem "webrick", "~> 1.8"
end 

Jigsaw52 added a commit to GDR-Verderena/gdr-verderena.github.io that referenced this issue Mar 5, 2024
Jigsaw52 added a commit to GDR-Verderena/gdr-verderena.github.io that referenced this issue Mar 5, 2024
Jigsaw52 added a commit to GDR-Verderena/gdr-verderena.github.io that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants