Find license files for hatch-built python dependencies #547
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatch puts files in .dist-info/licenses
|
the licenses CI job didn't create a PR to update the out of date dependency metadata because this branch name ends in |
jonabc
added a commit
that referenced
this pull request
Oct 7, 2022
## 3.7.4 ### Fixed - Licenses for Python dependencies built with Hatchling are correctly found (#547)
Merged
|
fyi that directory will be the new standard https://peps.python.org/pep-0639/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python wheels built using hatch installs files in a "licenses" folder under
dist-info, which was not previously being looked at. Longer term it might be better to examine all files underdist-infofor license contents but this is an ok option in the short term to fix the immediate issue where license files aren't found.