Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for chords to mapper tool #89

Open
iansan5653 opened this issue Sep 8, 2023 · 0 comments
Open

Add support for chords to mapper tool #89

iansan5653 opened this issue Sep 8, 2023 · 0 comments

Comments

@iansan5653
Copy link
Member

iansan5653 commented Sep 8, 2023

It would be great if we could also display chords in the mapper tool, similarly to VSCode.

I dug into this a bit and it's more complicated than I expected. If you just have a timer and track keydown events, you get chords like Meta Meta+b because the keydown for Meta is different from the keydown for b. It looks like this is solved in the main code with the 'radix trie' logic, but this seems pretty closely tied to the hotkeys that are configured on the element, and we can't configure all possible hotkeys onto the mapper tool.

@iansan5653 iansan5653 changed the title Hotkey Mapper Tool improvements Add support for chords to mapper tool Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant