Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22.
@koddsson: As discussed in our 1:1, I didn't like the idea of allowing
.click()
on any oddrole="button"
elements, but I also felt that even requiring[tabindex]
with[role]
would be a half measure.So I propose–– Instead of adding
role="button"
into the approved list of clickable selectors, we remove the constraint altogether. This will also allow hotkey to work on Custom Elements withdelegatedFocus
(github/details-dialog-element#26).To ease my own concern with hotkey getting abused (😬), I added a paragraph to the Accessibility considerations in the README.