Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger click on anything #24

Merged
merged 4 commits into from Oct 24, 2019
Merged

Trigger click on anything #24

merged 4 commits into from Oct 24, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Oct 23, 2019

Closes #22.

@koddsson: As discussed in our 1:1, I didn't like the idea of allowing .click() on any odd role="button" elements, but I also felt that even requiring [tabindex] with [role] would be a half measure.

So I propose–– Instead of adding role="button" into the approved list of clickable selectors, we remove the constraint altogether. This will also allow hotkey to work on Custom Elements with delegatedFocus (github/details-dialog-element#26).

To ease my own concern with hotkey getting abused (😬), I added a paragraph to the Accessibility considerations in the README.

@muan muan requested a review from a team October 23, 2019 22:12
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Applications can lint for the element types if they'd like and now this won't constrict the application developers.

@muan muan merged commit 128bdfc into master Oct 24, 2019
@muan muan deleted the click-anything branch October 24, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants