Rename app config #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
force-pushed
the
rename-app-config
branch
from
80c2a77
to
6b23802
Compare
keithamus
reviewed
Mar 19, 2020
bin/eslint-github-init.js
Outdated
| @@ -47,7 +47,7 @@ const questions = [ | |||
| } | |||
| ] | |||
|
|
|||
| inquirer.prompt(questions).then(answers => { | |||
| for (const answers of inquirer.prompt(questions)) { | |||
There was a problem hiding this comment.
Oh shoot, this was supposed to be a await/async conversion and not a for-of one.
bin/github-lint.js
Outdated
| process.stderr.write(`\nCommand failed: ${nonzero}\n`) | ||
| process.exit(nonzero) | ||
| } | ||
| }) |
There was a problem hiding this comment.
This doesn't look right. There needs to be parens to call this function
keithamus
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the
appconfig is:Even though we have a
browserconfig already. This PR renames theappconfig, theinternalconfig and makes sure that it only loads rules that internal github applications would want.Also removed the
es6part of the docs because I missed them in #96