Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused module rules and scripts #95

Merged
merged 1 commit into from Mar 18, 2020
Merged

Remove unused module rules and scripts #95

merged 1 commit into from Mar 18, 2020

Conversation

koddsson
Copy link
Contributor

Remove the unused modules rules and scripts from the package.

This part has been split out from #90 to be more reviewable.

This is a breaking change and will be published as major version 4 once everything from #90 has been merged into master.

@koddsson koddsson added this to the 4.0.0 milestone Mar 18, 2020
@koddsson koddsson requested a review from a team March 18, 2020 13:38
keithamus
keithamus approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are worth removing because our build tooling can automatically "tree shake" unused modules, so it is of little concern to have as a lint rule, plus these rules can be quite slow to run on large codebases.

@koddsson koddsson merged commit 6e4f49c into master Mar 18, 2020
@koddsson koddsson deleted the remove-unused-module-rules-and-scripts branch March 18, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koddsson @keithamus