Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add typescript support #406

Open
kayla-glick opened this issue Feb 23, 2023 · 1 comment
Open

Request: Add typescript support #406

kayla-glick opened this issue Feb 23, 2023 · 1 comment

Comments

@kayla-glick
Copy link

I'm working on an addition to insights-web (PR) that requires an upgrade to Chart.js 4. Chart.js 4 added typescript .d.ts definitions for various exported types. This breaks the GitHub eslint rules because the linter isn't able to resolve the imported types, despite everything compiling correctly. I was able to fix the linting by adding and configuring eslint-import-resolver-typescript to the project. I wanted to submit this issue here though because this seems like a better addition to estlint-plugin-github, that way we have org-wide TS linting support. There's also an alternative eslint-plugin-i package that claims to be faster than eslint-plugin-import.

@silverwind
Copy link

Imho, typescript should be optional in a separate package, e.g. eslint-plugin-github-typescript, so that people who use it for JS don't pull in a huge load of typescript-related dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants