Bump eslint-plugin-jsx-a11y to 6.7.1 #395
Conversation
| 'github/role-supports-aria-props': 'error', | ||
| 'jsx-a11y/role-supports-aria-props': 'off', | ||
| 'jsx-a11y/no-aria-hidden-on-focusable': 'error', | ||
| 'jsx-a11y/anchor-ambiguous-text': [ |
There was a problem hiding this comment.
This rule replaces our a11y-no-generic-link-text. We need to explicitly enable it because its part of the jsx-a11y/strict ruleset.
Maybe we want to enable the strict ruleset but I don't know, I think we need to review it.
| 'jsx-a11y/anchor-ambiguous-text': [ | ||
| 'error', | ||
| { | ||
| words: ['this', 'more', 'read here', 'read more'], |
There was a problem hiding this comment.
Rules in addition to the defaults.
| @@ -1,4 +1,6 @@ | |||
| # No Generic Link Text | |||
| # No Generic Link Text [Deprecated] | |||
There was a problem hiding this comment.
馃摚 Any "best practice" or existing practice for deprecating a rule? I've just marked the rule as deprecated and removed it from the config.
There was a problem hiding this comment.
I think if github/a11y-no-generic-link-text has been completely removed form the code base then you could just delete this document altogether!
There was a problem hiding this comment.
Oh okay! I haven't removed the code yet. For this immediate release I will keep it marked as deprecated, then delete it entirely in follow-ups.
| @@ -1,4 +1,6 @@ | |||
| # No Generic Link Text | |||
| # No Generic Link Text [Deprecated] | |||
There was a problem hiding this comment.
I think if github/a11y-no-generic-link-text has been completely removed form the code base then you could just delete this document altogether!
Fixes: https://github.com/github/accessibility/issues/2917
This PR bumps the
eslint-plugin-jsx-a11ydependency from 6.6.0 to 6.7.1 which includes new rules and bug fixes.Check out the CHANGELOG for eslint-plugin-jsx-a11y.
This update includes a new rule
anchor-ambiguous-textwhich can replace our customa11y-no-generic-link-text.馃摚 Any "best practice" or existing practice for deprecating a rule? I've just marked the rule as deprecated and removed it from the config.