Don't extends configs in the browser and internal configs #108
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muan
approved these changes
May 26, 2020
|
For posterity: Me and & @muan talked in slack and decided to release this as a bug fix to v4 rather than releaseing v5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not apparent to consumers of this plugin that when they extend the
browserorinternalconfigs they are extending therecommendedconfig as well.By not extending them in those configs we make the consumers denote each config they want to extend and give them the freedom to compose those configs together however they want.
This is a breaking change for consumers that have been relying on getting the recommended rules through the other configs.