Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include better error message #876

Merged
merged 3 commits into from Jan 21, 2022
Merged

Include better error message #876

merged 3 commits into from Jan 21, 2022

Conversation

aeisenberg
Copy link
Contributor

When users call init multiple times. This PR addresses an error that we saw in our telemetry. It looks like there was a user who was calling the init action multiple times in the same job and getting an error. This seems like an error that new users will come across when they want to analyze databases for multiple languages.

This PR makes the error message clearer in this case.

@edoardopirovano suggested a more robust fix where we introduce a UserError and handle them differently from Errors. This PR does not implement the suggestion, but is something we can do in the future.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner January 19, 2022 16:52
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, seems reasonable to me.

@aeisenberg
Copy link
Contributor Author

I'll update the changelog and then merge. Thanks for the review.

When users call init multiple times.
Add a line item for using a better error message.

Also, add a link for an entry that didn't have one before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants