Fix status reporting error on Windows #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cklin
force-pushed
the
windows-status-report-error
branch
3 times, most recently
from
958837c
to
29199f4
Compare
cklin
changed the title
edoardopirovano
approved these changes
Apr 26, 2022
aibaars
approved these changes
Apr 26, 2022
cklin
force-pushed
the
windows-status-report-error
branch
from
29199f4
to
6dd9baf
Compare
This was referenced Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1041
Status reporting currently fails on Windows because the CodeQL CLI version number retrieved by the action contains trailing
\r\nline ending (so2.8.5\r\ninstead of2.8.5). Interestingly, the reported CodeQL CLI version similarly contains\nline ending, but that for some reason did not cause server-side validation failure.This PR fixes the bug by trimming whitespace from
codeql version --format=terseoutput.Merge / deployment checklist