Add runner OS and arch to status report #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Mar 2, 2022
aeisenberg
approved these changes
Mar 3, 2022
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
cklin
force-pushed
the
report-runner-os-arch
branch
from
a6bd509
to
870dbaa
Compare
aeisenberg
reviewed
Mar 3, 2022
| @@ -692,6 +695,9 @@ export async function createStatusReportBase( | |||
| if (matrix) { | |||
| statusReport.matrix_vars = matrix; | |||
| } | |||
| if (runnerOs === "Windows" || runnerOs === "macOS") { | |||
| statusReport.runner_os_release = os.release(); | |||
There was a problem hiding this comment.
Is there a reason not to do this on linux? I just tried on one of my codespaces and I get:
Welcome to Node.js v14.17.6.
Type ".help" for more information.
> require('os').release()
'5.4.0-1069-azure'
It's not in x.y.z form, but it's still valid. I think it's the kernel version.
There was a problem hiding this comment.
There are a few reasons.
- We want to limit the cardinality of the status values reported, and there are many more variations for Linux kernel release strings than for Windows and macOS release versions.
- Linux kernel release IDs may contain custom strings, and we want to avoid recording private data (for custom kernel builds on self-hosted runners, for example).
- Windows and macOS release strings are more useful because they are representative of the entire system configuration (whether you are running Windows 10 or Windows 11, for example). Linux kernel versions are less coupled with the userspace environment—5.11.3 on RedHat could be very different from 5.11.3 on Ubuntu.
So we are recording OS releases only for Windows and macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist
This PR adds the OS and architecture (as reported by the GitHub Action Runner environments
RUNNER_OSandRUNNER_ARCH) to the status report.