Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node.js v16 in all Actions #909

Merged
merged 6 commits into from Feb 8, 2022
Merged

Conversation

henrymercer
Copy link
Contributor

Node.js v16 is in active LTS status and is now the default for Actions, so this PR upgrades to it. This warrants a minor version bump, so we bump the version to v1.1.0. As a bonus we remove some stub type definitions.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner February 3, 2022 18:02
@henrymercer henrymercer force-pushed the henrymercer/bump-node-js-to-v16 branch from 1a8a10b to 1ed6569 Compare February 3, 2022 19:07
@henrymercer
Copy link
Contributor Author

I'll hold off merging this until the next release is out, so this can sit in main for a little while before being released to v1.

@henrymercer henrymercer mentioned this pull request Feb 7, 2022
3 tasks
@aeisenberg
Copy link
Contributor

v1.0.32 was just released. Should we merge this one now?

@henrymercer henrymercer force-pushed the henrymercer/bump-node-js-to-v16 branch from 1ed6569 to 3db84ce Compare February 8, 2022 10:28
@henrymercer
Copy link
Contributor Author

Rebased on main

@henrymercer
Copy link
Contributor Author

Some CI jobs are failing due to the windows-latest image migrating to Windows Server 2022. Will address those in a separate PR.

@henrymercer henrymercer force-pushed the henrymercer/bump-node-js-to-v16 branch from 3db84ce to 007f040 Compare February 8, 2022 12:08
@henrymercer henrymercer changed the base branch from main to henrymercer/fix-windows-latest-ci-jobs February 8, 2022 12:09
@henrymercer henrymercer force-pushed the henrymercer/bump-node-js-to-v16 branch 2 times, most recently from f35e5d7 to 6f89a18 Compare February 8, 2022 12:53
@henrymercer henrymercer force-pushed the henrymercer/fix-windows-latest-ci-jobs branch from e43cec9 to 2ebc770 Compare February 8, 2022 13:31
@henrymercer henrymercer force-pushed the henrymercer/bump-node-js-to-v16 branch from 6f89a18 to a8e4927 Compare February 8, 2022 13:33
@henrymercer henrymercer force-pushed the henrymercer/fix-windows-latest-ci-jobs branch from 2ebc770 to 8dd2b9a Compare February 8, 2022 13:50
This is now in active LTS status.
The upgrade to Node.js v16 warrants a minor version bump.
@henrymercer henrymercer force-pushed the henrymercer/bump-node-js-to-v16 branch 2 times, most recently from f7b9ff3 to 76b7276 Compare February 8, 2022 16:19
@henrymercer henrymercer force-pushed the henrymercer/bump-node-js-to-v16 branch from 76b7276 to 8f27994 Compare February 8, 2022 16:19
Base automatically changed from henrymercer/fix-windows-latest-ci-jobs to main February 8, 2022 17:05
@henrymercer henrymercer merged commit 88073a5 into main Feb 8, 2022
@henrymercer henrymercer deleted the henrymercer/bump-node-js-to-v16 branch February 8, 2022 18:32
@github-actions github-actions bot mentioned this pull request Feb 11, 2022
5 tasks
@henrymercer henrymercer mentioned this pull request Feb 17, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants