Make name of debugging artifact and DB within it configurable #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardopirovano
force-pushed
the
debug-artifact-name
branch
from
b497e2e
to
70a29ef
Compare
esbena
reviewed
Jan 7, 2022
edoardopirovano
force-pushed
the
debug-artifact-name
branch
from
70a29ef
to
206e16e
Compare
edoardopirovano
force-pushed
the
debug-artifact-name
branch
from
206e16e
to
e677af3
Compare
edoardopirovano
changed the title
aeisenberg
reviewed
Jan 7, 2022
| config.dbLocation, | ||
| `${databasePath}.zip` | ||
| ); | ||
| const databaseBundlePath = path.resolve(config.dbLocation, `${dbName}.zip`); |
There was a problem hiding this comment.
So, this will now place the bundled db in a different location? I don't think that's a problem, but it is a change and just want to be sure.
There was a problem hiding this comment.
Indeed, that is correct. I hope there's no code outside the codeql-action that is relying on where we happen to put the DB bundles before uploading them to an artifact. I don't think that's a use-case we've ever claimed to support, nor do I think we should be supporting it, so I think it is okay to break.
aeisenberg
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @esbena and @hvitved for use on DCA.
Adds two new options next to the
debugModeone to control the name of the debugging artifact uploaded and the name of the database within that artifact. This is needed on DCA because it uses the Action multiple times within one workflow with different SHAs that it is comparing, so without this the debugging artifacts will overwrite each-other. It may also be useful to users who want their debugging artifacts to have more meaningful names.@robertbrignull This changes the code that calls
codeql database bundlewhich is also called by the code that uploads databases to Remote Queries. In the Remote Queries instance of this case, I have passed in justlanguageas the name of the DB. This is what was (implicitly) being used before, so I believe this change to be behaviour-preserving from the point of view of Remote Queries. You may want to check it nonetheless.Merge / deployment checklist