Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing python tests #778

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Fix failing python tests #778

merged 2 commits into from
Oct 15, 2021

Conversation

aeisenberg
Copy link
Contributor

The requests module 1.2.3 is no longer compatible with python >=3.10.0.
So, instead use 2.26.0, the most recent version that is compatible with
our supported python versions at the time of this commit.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • [n/a] Confirm the readme has been updated if necessary.
  • [n/a] Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner October 14, 2021 19:32
@aeisenberg
Copy link
Contributor Author

@Daverlo could you review this. I believe you originally wrote these python tests. With these changes, I am not sure if the workflows are still testing the things you are intending them to test.

@aibaars
Copy link
Collaborator

aibaars commented Oct 14, 2021

Was the xxx file committed by accident?

@aeisenberg
Copy link
Contributor Author

Yes...let me remove that.

@aeisenberg
Fix failing python tests
3df2172 
The requests module 1.2.3 is no longer compatible with python >=3.10.0.
So, instead use 2.26.0, the most recent version that is compatible with
our supported python versions at the time of this commit.
aibaars
aibaars reviewed Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I wonder if we could leave the "*" version specifiers unchanged.

python-setup/tests/pipenv/python-3.8/Pipfile Outdated
@@ -6,7 +6,7 @@ verify_ssl = true
[dev-packages]

[packages]
requests = "*"
requests = "2.26.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change could be reverted, hopefully the version from the lock file will be taken.

python-setup/tests/pipenv/requests-2/Pipfile Outdated
@@ -6,7 +6,7 @@ verify_ssl = true
[dev-packages]

[packages]
requests = "*"
requests = "2.26.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change could be reverted, hopefully the version from the lock file will be taken.

python-setup/tests/pipenv/requests-3/Pipfile Outdated
@@ -6,6 +6,6 @@ verify_ssl = true
[dev-packages]

[packages]
requests = "*"
requests = "2.26.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change could be reverted, hopefully the version from the lock file will be taken.

python-setup/tests/poetry/python-3.8/pyproject.toml Outdated
@@ -6,7 +6,7 @@ authors = ["Your Name <you@example.com>"]

[tool.poetry.dependencies]
python = "^3.8"
requests = "*"
requests = "2.26.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change could be reverted, hopefully the version from the lock file will be taken.

python-setup/tests/poetry/requests-3/pyproject.toml Outdated
python = "^3.5"
requests = "*"
python = "^3.6"
requests = "2.26.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change could be reverted, hopefully the version from the lock file will be taken.

Suggested change
requests = "2.26.0"
requests = "*"

@aeisenberg
Remove explicit 2.26.0 version in python tests
43ea2ce 
Also, rename test scripts to indicate the version they are using.
@aibaars aibaars merged commit 286a237 into main Oct 15, 2021
@aibaars aibaars deleted the aeisenberg/fix-python-tests branch October 15, 2021 09:42
@github-actions github-actions bot mentioned this pull request Oct 18, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

@Daverlo Daverlo Awaiting requested review from Daverlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aeisenberg @aibaars