Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning PRs to merger doesn't work when they're auto-merged #2137

Open
jsoref opened this issue Feb 13, 2024 · 0 comments
Open

Assigning PRs to merger doesn't work when they're auto-merged #2137

jsoref opened this issue Feb 13, 2024 · 0 comments

Comments

@jsoref
Copy link
Contributor

jsoref commented Feb 13, 2024

A bunch of [@jsoref's] PRs are assigned to the people who merged them. It feels like the automation hasn't contemplated that PRs would be written by people who can't/won't be the people who will click the "merge" button.

This is intentional:

# Get the person who merged the pull request.
# For most cases this will be the same as the author, but for PRs opened
# by external contributors getting the merger will get us the GitHub
# employee who reviewed and merged the PR.
def get_merger_of_pr(repo, pr):
return repo.get_commit(pr.merge_commit_sha).author.login

More interesting is that this approach seems to break when enabling auto-merge as can be seen here:
(merged by @angelapwen but PR is from @jsoref)

#2110 (@jsoref)

Originally posted by @intrigus-lgtm in #2131 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant