Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature flags for bypassing the toolcache #1529

Merged
merged 1 commit into from Feb 8, 2023
Merged

Remove feature flags for bypassing the toolcache #1529

merged 1 commit into from Feb 8, 2023

Conversation

henrymercer
Copy link
Contributor

  • We can now use the default bundle version feature flags to remediate a bad bundle update.
  • Controlled switchover ensures that a repo consistently gets the same bundle version, so we no longer have alert churn concerns with Kotlin and Swift.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer
Remove feature flags for bypassing the toolcache
db534af 
- We can now use the default bundle version feature flags to remediate a
bad bundle update.
- Controlled switchover ensures that a repo consistently gets the same
bundle version, so we no longer have alert churn concerns with Kotlin
and Swift.
@henrymercer henrymercer requested a review from a team as a code owner February 8, 2023 15:23
angelapwen
angelapwen approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very satisfying ✨

@henrymercer
Copy link
Contributor Author

🔥

@henrymercer henrymercer merged commit c4e22e9 into main Feb 8, 2023
@henrymercer henrymercer deleted the henrymercer/remove-bypass-toolcache-flags branch February 8, 2023 18:13
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Merged
6 tasks
@aliscco aliscco mentioned this pull request Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henrymercer @angelapwen