Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-required-checks.sh: fix argument handling #1421

Merged
merged 3 commits into from Dec 8, 2022
Merged

update-required-checks.sh: fix argument handling #1421

merged 3 commits into from Dec 8, 2022

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Dec 7, 2022

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@cklin cklin requested a review from a team as a code owner December 7, 2022 18:14
henrymercer
henrymercer previously approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I guess we haven't passed a SHA to this script for a while... thanks!

@henrymercer
Copy link
Contributor

While we're here, perhaps we should also add check-expected-release-files to the ignore list on line 26. I noticed that this is appearing as an expected check here, but it only runs when certain paths are changed.

@cklin cklin merged commit 10c8997 into main Dec 8, 2022
@cklin cklin deleted the cklin/fix-update-required-checks-sha branch December 8, 2022 17:06
This was referenced Dec 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cklin @henrymercer