Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the merge into releases/v2 #1308

Merged
merged 17 commits into from Oct 17, 2022
Merged

Fix the merge into releases/v2 #1308

merged 17 commits into from Oct 17, 2022

Conversation

aeisenberg
Copy link
Contributor

This PR re-merges main@e4cc4a2f into releases/v2. It fixes an accidental squash merge from main into releases/v2.

github-actions[bot] and others added 17 commits September 29, 2022 17:46
Mergeback v2.1.26 refs/heads/releases/v2 into main
Co-authored-by: GitHub <noreply@github.com>
TRAP Caching: Add timeouts to upload/download operations
It's possible to determine this otherwise, but this makes it easier to
spot.
The user config parser in the CLI doesn't yet support it.
Add logging statements declaring state of the cli_config_file_enabled
* Correctly report CodeQL version when using cache

* Add JS generated files

* Add test for return value of `setupCodeQL`

* Fill in missing return value comment
Convert "Invalid source root" errors to UserErrors
* Add changelog note for Go extraction reconciliation

* Update CHANGELOG.md

Co-authored-by: Henry Mercer <henrymercer@github.com>

* Update CHANGELOG.md

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>

* Tweaks from PR review

Co-authored-by: Henry Mercer <henrymercer@github.com>
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@henrymercer
Copy link
Contributor

Note that we should be careful when backporting this to main, because 4c1ccc4a5e98ce02155843e6f5c112ce81c87f53 might confuse the merge strategy and give us a bad CHANGELOG.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants