Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CliConfigFileEnabled feature flag #1270

Merged
merged 3 commits into from Sep 28, 2022

Conversation

aeisenberg
Copy link
Contributor

Also, wire it up to the useCodeScanningConfigInCli function.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner September 27, 2022 02:57
henrymercer
henrymercer previously approved these changes Sep 27, 2022
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there's a typo here

src/util.ts Outdated Show resolved Hide resolved
@aeisenberg
Copy link
Contributor Author

I'm going to add some unit tests.

Also, wire it up to the `useCodeScanningConfigInCli` function.
@aeisenberg aeisenberg force-pushed the aeisenberg/cli-config-feature-flag branch from 22bbeb8 to e37b0d6 Compare September 27, 2022 14:58
src/util.test.ts Outdated Show resolved Hide resolved
src/util.test.ts Outdated Show resolved Hide resolved
angelapwen
angelapwen previously approved these changes Sep 27, 2022
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😸

@angelapwen
Copy link
Contributor

Autogenerated JS files are not up to date, but otherwise ✅

@angelapwen
Copy link
Contributor

I think the failures are related to the Go extraction feature flag I just enabled. I un-enabled it again and they should work on re-run.

@aeisenberg
Copy link
Contributor Author

Hmmm...required check Download and check debug artifacts is marked as "expected". I'm not sure why it's not running.

@angelapwen
Copy link
Contributor

Hmmm...required check Download and check debug artifacts is marked as "expected". I'm not sure why it's not running.

I've seen this before. I think it's waiting on the upload jobs it depends on to finish, and then it will run.

@aeisenberg
Copy link
Contributor Author

Well...I merged with main and updated all required checks. Hopefully, this is enough to fix things. Yours may have been an easier solution.

@aeisenberg aeisenberg merged commit 74740ee into main Sep 28, 2022
@aeisenberg aeisenberg deleted the aeisenberg/cli-config-feature-flag branch September 28, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants