Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move Runner checks into their own workflow #1158

Merged
merged 1 commit into from Jul 29, 2022

Conversation

adityasharad
Copy link
Contributor

Refactor the PR checks workflow into two workflows: PR checks and Runner checks.

This does not change the actual check jobs that are run.
It also does not change the expected check names (which rely only on the job name, not the workflow name).

This makes it easier to inspect workflow run summaries in the UI and to separately retry subsets of failed jobs in case of flakiness.

In future we will clean up the Runner checks, since this is a deprecated component.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • [N/A] Confirm the readme has been updated if necessary.
  • [N/A] Confirm the changelog has been updated if necessary.

Refactor the PR checks workflow into two workflows:
PR checks and Runner checks.

This does not change the actual check jobs that are run.
It also does not change the expected check names
(which rely only on the job name, not the workflow name).

This makes it easier to inspect workflow run summaries in the UI
and to separately retry subsets of failed jobs in case of flakiness.

In future we will clean up the Runner checks,
since this is a deprecated component.
@adityasharad adityasharad requested a review from a team as a code owner July 28, 2022 23:51
@aeisenberg
Copy link
Contributor

I think we just got unlucky with that check that timedout.

@adityasharad adityasharad merged commit 495c200 into main Jul 29, 2022
@adityasharad adityasharad deleted the adityasharad/actions/separate-runner-checks branch July 29, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants