Remove outdated guidance on missing analysis #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of December 2021, we do not return missing base analysis anymore.
henrymercer
reviewed
May 17, 2022
henrymercer
approved these changes
May 17, 2022
|
Thanks for this PR. Does this mean that the docs should be updated as well? |
aeisenberg
approved these changes
May 17, 2022
Yes, I have an open issue on the docs repo for this (backlinked). Waiting for it to be picked-up by their First Responder. |
This was referenced Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of December 2021, we do not return missing base analysis anymore. Instead on the PR that introduces code scanning, we will report all alerts as new.
We can still report a missing after, especially when we deal with outdated configurations, but that should happen significantly less often (and was also not originally explained in this paragraph).
Merge / deployment checklist