Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing errors being caught and logged as a warning rather than failing the workflow run. #1055

Merged
merged 1 commit into from
May 3, 2022

Conversation

chrisgavin
Copy link
Contributor

The catch block here was intended to mean the workflow doesn't fail if the GitHub API is unreachable, but it also has the side effect of converting the processing errors into warnings.

If there definitively are processing errors I think we want to fail the workflow to make them more obvious.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@chrisgavin chrisgavin force-pushed the fix-status-error-being-caught branch from 517bc2f to 1fc7ebc Compare May 3, 2022 08:51
@chrisgavin chrisgavin force-pushed the fix-status-error-being-caught branch from 1fc7ebc to 366e88c Compare May 3, 2022 09:06
@chrisgavin chrisgavin marked this pull request as ready for review May 3, 2022 09:47
@chrisgavin chrisgavin requested a review from a team as a code owner May 3, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants