Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running ML-powered queries on Windows #1010

Merged

Conversation

henrymercer
Copy link
Contributor

We have some evidence to suggest that some runs on Windows cause CatastrophicErrors which abort the analysis. This PR stops running ML-powered queries on Windows while we address this problem.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too bad...looks reasonable to me.

@henrymercer henrymercer marked this pull request as ready for review March 30, 2022 18:20
@henrymercer henrymercer requested a review from a team as a code owner March 30, 2022 18:20
@henrymercer henrymercer merged commit 9dcc141 into main Mar 30, 2022
@henrymercer henrymercer deleted the henrymercer/stop-running-ml-powered-queries-on-windows branch March 30, 2022 18:57
This was referenced Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants