Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*Matches/Matching properties are not applied to the full string (e.g. current branch) #359

Closed
famod opened this issue May 28, 2021 · 0 comments · Fixed by #360
Closed

*Matches/Matching properties are not applied to the full string (e.g. current branch) #359

famod opened this issue May 28, 2021 · 0 comments · Fixed by #360
Labels
bug
Milestone
release-3.14.2

Comments

@famod
Copy link
Member

famod commented May 28, 2021

gib.disableIfBranchMatches=\d+\.\d+ (for release branches like in Quarkus, e.g. 1.13) will also match bump-xyz-to-1.1 or similar.

This is not the intended behavior as this will catch too much. Given that those are regular expressions, you can easily use e.g. .* to get a substring match behavior.
@famod famod added the bug label May 28, 2021
@famod famod added this to the release-3.14.2 milestone May 28, 2021
famod added a commit to famod/gitflow-incremental-builder that referenced this issue May 28, 2021
@famod
Change *Match/Matching properties to match full string instead of sub…
6cbf30a 
…string

Fixes gitflow-incremental-builder#359
@famod famod changed the title *Matches properties are not applied to the full string (e.g. current branch) *Matches/Matching properties are not applied to the full string (e.g. current branch) May 28, 2021
@famod famod mentioned this issue May 28, 2021
Merged
@famod famod mentioned this issue Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
release-3.14.2
1 participant
@famod