Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping "Regex" suffix from various properties #309

Closed
famod opened this issue Feb 15, 2021 · 0 comments · Fixed by #326
Closed

Consider dropping "Regex" suffix from various properties #309

famod opened this issue Feb 15, 2021 · 0 comments · Fixed by #326
Labels
enhancement
Milestone
release-3.13.0

Comments

@famod
Copy link
Member

famod commented Feb 15, 2021 •
edited

Given the new skipIfPathMatches property (#310), something like this would be more readable:

  • disableIfBranchRegex -> disableIfBranchMatches
  • excludePathRegex -> excludePathMatching (or even "...PathsMatching")
  • includePathRegex -> includePathMatching (...)
@famod famod added this to the release-3.13.0 milestone Feb 16, 2021
famod added a commit to famod/gitflow-incremental-builder that referenced this issue Mar 13, 2021
@famod
Rename *Regex properties to *Matching/*Matches
7a4e465 
Resolves gitflow-incremental-builder#309
@famod famod mentioned this issue Mar 13, 2021
Merged
1 task
famod added a commit to famod/gitflow-incremental-builder that referenced this issue Mar 14, 2021
@famod
Rename *Regex properties to *Matching/*Matches
b8916f6 
Resolves gitflow-incremental-builder#309
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
release-3.13.0
Development

Successfully merging a pull request may close this issue.

Rename *Regex properties to *Matching/*Matches famod/gitflow-incremental-builder
1 participant
@famod