Consider building upstream modules regardless of being changed or not when using -pl and -am

[famod]

See https://github.com/vackosar/gitflow-incremental-builder#mvn--pl:

• Upstream projects of these selected projects are built if:
  • -am (--also-make) is used
  • and:
    • they are changed (or depend on other changed upstream modules) and buildUpstream is not never or false
    • or buildAll is enabled

More specifically this part:

they are changed (or depend on other changed upstream modules)

I had a reason to implement it like this but I don't remember. Actually I now think this is counterintuitive and the condition should be dropped.

[famod]

@mickroll Do you have an opinion about this?

[mickroll]

I see 2 main use cases for gib:

• ci builds, where only changed modules should be built, on top of an existing workspace of an earlier build.
• local, day to day builds where gib should 'not get in the way' (which means something different for any dev)

CI builds may use some more gib configuration, as it is not changed very often.
Local builds should be not need a lot of config parameters. If i supply mvn with a project list, i expect it to be built, regardless of detected changes. So:

• -pl should skip change detection
• -am, -amd and -rf should also skip change detection

Maybe there is a way to use properties like -Dgib.am (like mvn -am) to have a clear distinction between gib-enhanced and mvn-default behaviour? This would end the discussion which behaviour is 'best' and enable users to directly tell mvn/gib what they want. No guesswork needed.

[famod]

At some point, I actually thought about something like -Dgib.am but it somehow felt like reinventing the wheel.
Besides, there is already -Dgib.buildUpstream=... (and -Dgib.buildDownstream). Maybe changed could be added as value.

So, basically you confirmed what I was thinking. Thanks!