Fewer modules are built with GIB than without it when -rf is used

[famod]

Observed by @maschoene:

• 4 modules A, B, C, D
• D needs B & C
• B & C need A
• A and B are changed
• -rf :B only builds B & D, but B, C and D are expected

Without GIB, B, C and D are built.

[famod]

I need to check this but I guess no downstream is calculated for A because it is "deselected" via -rf.

@gastaldi I think this will also affect the -pl single-project use case in some of the Quarkus CI jobs since this is also "deselecting" modules (all except the selected ones).

[famod]

@maschoene

Hm, could not reproduce it:

[INFO] Scanning for projects...
[INFO] gitflow-incremental-builder 3.11.3 starting...
[INFO] ------------------------------------------------------------------------
[INFO] Changed Artifacts:
[INFO]
[INFO] bar.A (but deselected)
[INFO] bar.B
[INFO]
[INFO] gitflow-incremental-builder exiting...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] bar.B                                                              [jar]
[INFO] bar.C                                                              [jar]
[INFO] bar.D                                                              [jar]

I'll have a look at the original scenario (our internal project). Something must be different.

@gastaldi Good news, we just a need a new property that disables all "convenience features" for "selected projects" to make -pl work like we discussed.
So for now it seems the two issues do not have a common cause.

[famod]

To be clarified after @maschoene has returned from PTO.

FTR: Maven itself (without GIB) does not build C in the mentioned internal project (which is far more complex than my simple reproducer).

[famod]

Turns out that this got fixed as a side effect of #288.