{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":164717119,"defaultBranch":"master","name":"ember.js","ownerLogin":"gitKrystan","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-01-08T19:20:38.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/14152574?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1692747150.0","currentOid":""},"activityList":{"items":[{"before":"208d9bcd575301c573f6bfae04ca65c1e66eded7","after":"6cdb9e4efb7865531828bcb8451b0ca8f46f00d4","ref":"refs/heads/error-error","pushedAt":"2023-08-22T23:35:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"},"commit":{"message":"Don't rethrow string errors in handleTransitionReject\n\n`handleTransitionReject` blindly rethrows `error.error` regardless of its type. While the code appears to assume that the error will be of type `TransitionError`, `handleTransitionReject` might be called with another error type.\n\nNewer versions of EmberData will throw an error that has `error.error` (https://github.com/emberjs/data/blob/f0dd0d429052abe3ce49e4e87f3492691e62d523/ember-data-types/cache/document.ts#L59) and when this happens, this code is rethrowing the string/object error unexpectedly.\n\nBased on https://github.com/tildeio/router.js/blob/9320c7b1c1e887e73afd3700cd0093b9f34c9e6b/lib/router/transition-state.ts#L124 it looks like the type for `TransitionError` should be `Error`, and generally it sames safe enough to rethrow as long as the `error.error` is itself an `Error`. :)\n\nNewer versions of EmberData will throw an error that has `error.error`","shortMessageHtmlLink":"Don't rethrow string errors in handleTransitionReject"}},{"before":null,"after":"208d9bcd575301c573f6bfae04ca65c1e66eded7","ref":"refs/heads/error-error","pushedAt":"2023-08-22T23:32:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"},"commit":{"message":"Don't rethrow string errors in handleTransitionReject\n\n`handleTransitionReject` blindly rethrows `error.error` regardless of its type. While the code appears to assume that the error will be of type `TransitionError`, `handleTransitionReject` might be called with another error type.\n\nNewer versions of EmberData will throw an error that has `error.error` (https://github.com/emberjs/data/blob/f0dd0d429052abe3ce49e4e87f3492691e62d523/ember-data-types/cache/document.ts#L59) and when this happens, this code is rethrowing the string/object error unexpectedly.\n\nBased on https://github.com/tildeio/router.js/blob/9320c7b1c1e887e73afd3700cd0093b9f34c9e6b/lib/router/transition-state.ts#L124 it looks like the type for `TransitionError` should be `Error`, and generally it sames safe enough to rethrow as long as the `error.error` is itself an `Error`. :)\n\nNewer versions of EmberData will throw an error that has `error.error`","shortMessageHtmlLink":"Don't rethrow string errors in handleTransitionReject"}},{"before":"3746d7dc4cf4bc3561e2ef9198becc7a0bb118c4","after":null,"ref":"refs/heads/backport-20388-to-4-4","pushedAt":"2023-04-27T23:19:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"}},{"before":"281760d087df8f81239d7d8d318bd475dee600a5","after":"3746d7dc4cf4bc3561e2ef9198becc7a0bb118c4","ref":"refs/heads/backport-20388-to-4-4","pushedAt":"2023-04-27T22:50:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wycats","name":"Yehuda Katz","path":"/wycats","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4?s=80&v=4"},"commit":{"message":"[BUGFIX beta] Update Node.js versions to match support policy\n\nEmber CLI dropped support for Node 12 in 4.6.0.","shortMessageHtmlLink":"[BUGFIX beta] Update Node.js versions to match support policy"}},{"before":"5e17b73be410c43e463329167ba135274c088a74","after":"281760d087df8f81239d7d8d318bd475dee600a5","ref":"refs/heads/backport-20388-to-4-4","pushedAt":"2023-04-27T22:39:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wycats","name":"Yehuda Katz","path":"/wycats","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4?s=80&v=4"},"commit":{"message":"Try to bump node version","shortMessageHtmlLink":"Try to bump node version"}},{"before":"3979f49f94d9eafe142e8e0aa121760dbdbfb9da","after":"5e17b73be410c43e463329167ba135274c088a74","ref":"refs/heads/backport-20388-to-4-4","pushedAt":"2023-04-27T22:38:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wycats","name":"Yehuda Katz","path":"/wycats","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4?s=80&v=4"},"commit":{"message":"Try to bump node version","shortMessageHtmlLink":"Try to bump node version"}},{"before":"8017688b7738c41ce387908c987b2046aff291da","after":"3979f49f94d9eafe142e8e0aa121760dbdbfb9da","ref":"refs/heads/backport-20388-to-4-4","pushedAt":"2023-04-27T22:36:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"wycats","name":"Yehuda Katz","path":"/wycats","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4?s=80&v=4"},"commit":{"message":"Merge branch 'backport-20388-to-4-4' of https://github.com/gitkrystan/ember.js into pr/gitKrystan/20405","shortMessageHtmlLink":"Merge branch 'backport-20388-to-4-4' of <a href=\"https://github.com/gitkrystan/ember.js\">https://github.com/gitkrystan…</a>"}},{"before":"2f29e5693798174530b471dd1fcbb9e26f360bf1","after":"8017688b7738c41ce387908c987b2046aff291da","ref":"refs/heads/backport-20388-to-4-4","pushedAt":"2023-04-27T22:29:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wycats","name":"Yehuda Katz","path":"/wycats","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4?s=80&v=4"},"commit":{"message":"Try to bump node version","shortMessageHtmlLink":"Try to bump node version"}},{"before":null,"after":"2f29e5693798174530b471dd1fcbb9e26f360bf1","ref":"refs/heads/backport-20388-to-4-4","pushedAt":"2023-03-09T21:58:35.900Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"},"commit":{"message":"[BUGFIX LTS] Don't run getters while applying mixins\n\nThis change ensures that getters are never evaluated while applying\nmixins.\n\nIt relies on the fact that all getters (including undecorated ones) get\nconverted into classic decorators when the mixin is originally created.","shortMessageHtmlLink":"[BUGFIX LTS] Don't run getters while applying mixins"}},{"before":"2a9ab7a14c80a8da8a2ad6e89fb537402e6e23fb","after":"03bc5f92fa0edbda0823a90cdb034942d9e34439","ref":"refs/heads/master","pushedAt":"2023-03-09T21:49:10.552Z","pushType":"push","commitsCount":35,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"},"commit":{"message":"Merge pull request #20388 from emberjs/fix-zebra-mixins\n\n[BUGFIX LTS] Don't run getters while applying mixins","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1604021545\" data-permission-text=\"Title is private\" data-url=\"https://github.com/emberjs/ember.js/issues/20388\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/emberjs/ember.js/pull/20388/hovercard\" href=\"https://github.com/emberjs/ember.js/pull/20388\">emberjs#20388</a> from emberjs/fix-zebra-mixins"}},{"before":"d77b37b2d81784880c737fe45ba5624822013084","after":"8e9b4ab3a9e8a00dfdc545e29d71703c6d87ce98","ref":"refs/heads/addonified3.28","pushedAt":"2023-03-08T23:07:30.473Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"},"commit":{"message":"SQUASHED refactor-addon for dogfood","shortMessageHtmlLink":"SQUASHED refactor-addon for dogfood"}},{"before":"1c2ea72ab3d7d7ff809da2839415d828b946eb90","after":"d77b37b2d81784880c737fe45ba5624822013084","ref":"refs/heads/addonified3.28","pushedAt":"2023-03-08T22:53:05.872Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"},"commit":{"message":"SQUASHED refactor-addon for dogfood","shortMessageHtmlLink":"SQUASHED refactor-addon for dogfood"}},{"before":"27c7b8687ed7a4416def0b024bcfd4943a2c7da6","after":"1c2ea72ab3d7d7ff809da2839415d828b946eb90","ref":"refs/heads/addonified3.28","pushedAt":"2023-03-08T22:52:12.464Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"},"commit":{"message":"SQUASHED refactor-addon for dogfood","shortMessageHtmlLink":"SQUASHED refactor-addon for dogfood"}},{"before":null,"after":"27c7b8687ed7a4416def0b024bcfd4943a2c7da6","ref":"refs/heads/addonified3.28","pushedAt":"2023-03-08T22:42:47.020Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gitKrystan","name":"Krystan HuffMenne","path":"/gitKrystan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14152574?s=80&v=4"},"commit":{"message":"SQUASHED refactor-addon for dogfood","shortMessageHtmlLink":"SQUASHED refactor-addon for dogfood"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADcFYKRAA","startCursor":null,"endCursor":null}},"title":"Activity · gitKrystan/ember.js"}