Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git-artifacts builds after the recent upgrade to GCC v14.1 #4953

Closed
dscho opened this issue May 12, 2024 · 0 comments
Closed

Fix git-artifacts builds after the recent upgrade to GCC v14.1 #4953

dscho opened this issue May 12, 2024 · 0 comments
Milestone
Next release

Comments

@dscho
Copy link
Member

dscho commented May 12, 2024

The build fails thusly:

archive-zip.c: In function 'dos_time':
archive-zip.c:612:9: error: implicit declaration of function 'localtime_r'; did you mean 'localtime_s'? [-Wimplicit-function-declaration]
  612 |         localtime_r(&time, &tm);
      |         ^~~~~~~~~~~
      |         localtime_s

This might not be the only thing that is currently broken, so let's make sure to fix all of the issues preventing GCC v14.1 to build Git for Windows correctly.
@dscho dscho mentioned this issue May 21, 2024
Merged
dscho added a commit that referenced this issue May 22, 2024
@dscho
Fix build with GCC v14.1 (#4962)
f3b93ac 
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially,
this has been fixed upstream already, but the i686 build requires a
separate fix.

This addresses #4953.
@dscho dscho added this to the Next release milestone May 22, 2024
@dscho dscho closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next release
Development

No branches or pull requests
1 participant
@dscho