Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make injectAllReactorProjects less verbose. #431

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Make injectAllReactorProjects less verbose. #431

merged 1 commit into from
Aug 15, 2019

Conversation

ryantse
Copy link
Contributor

@ryantse ryantse commented Aug 15, 2019

Context

injectAllReactorProjects currently prints out each and every project that it injects the properties into. This change moves that to debug level logging only and instead only reports the number of projects that had this property injected into.

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@TheSnoozer
Copy link
Collaborator

Thank for your contribution!

LGTM.

@TheSnoozer TheSnoozer merged commit b88d305 into git-commit-id:master Aug 15, 2019
@TheSnoozer TheSnoozer added this to the 3.0.2 milestone Aug 15, 2019
@ryantse ryantse deleted the inject-properties-quieter branch August 15, 2019 17:30
@TheSnoozer TheSnoozer modified the milestones: 3.0.2, 4.0-modularized Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants