Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 8 support? #434

Closed
luckydonald opened this issue Jul 3, 2019 · 7 comments
Closed

PHPUnit 8 support? #434

luckydonald opened this issue Jul 3, 2019 · 7 comments

Comments

@luckydonald
Copy link

Since earlier this year PHPUnit 8 is out, and 9 is already being worked on.

So after support for PHPUnit 7 #422 is almost released,
According to commit aa5eb95 it is still missing some parts for compatibility.

@luckydonald
Copy link
Author

Oh, just found #432 related to that specific issue left to do.

@thewunder
Copy link
Collaborator

I'll help address this after we get 7 out the door

luckydonald added a commit to luckydonald-forks/phpunit-selenium that referenced this issue Jul 3, 2019
According to giorgiosironi#434 this is only for screenshots I don't use
@KevP
Copy link

KevP commented Nov 9, 2019

Any update?

@luckydonald
Copy link
Author

luckydonald commented Dec 3, 2019

@KevP
So far @thewunder has not left feedback in #432, which needs to be addressed before we can have a 8+ version.

Also using the fork (see #422 (comment)) might be a workaround if you don't need the screenshot class.

@pajon
Copy link
Collaborator

pajon commented Dec 18, 2019

PHPUnit 8.x support #441

@thewunder
Copy link
Collaborator

Thanks so much to @pajon for the great work!

@pajon
Copy link
Collaborator

pajon commented Mar 17, 2020

Your welcome. Do we have a roadmap about what to next to do with this package ? For me is important to add support PHPUnit 9.x and do some changes to support also w3c protocol. But before we dive into w3c we need change architecture. I think will be good to migrate from dynamic handling commands (__call + annotations) like we use it now to more explicitly. Using less annotations (properties + methods) which can be messy if you need to understant how some code work. What do you think about it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants