Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FullyShared Session Strategy (even in case of failures) #378

Open
amenk opened this issue May 6, 2016 · 1 comment
Open

Add FullyShared Session Strategy (even in case of failures) #378

amenk opened this issue May 6, 2016 · 1 comment

Comments

@amenk
Copy link

amenk commented May 6, 2016

I am testing on VMs (BrowserStack) and the overhead for one session is quite high (booting up a full ne VM, takes around 20 seconds).

So I am using \PHPUnit_Extensions_Selenium2TestCase_SessionStrategy_Shared to share session. Unfortunately there is code to restart the session in case the last test was not successful.

While this makes sense in some cases, in my case it does not.

Could we add a session strategy to not restart the session on failures? Or is it possible to add an own session strategy on-the-fly? (I did not yet succeed in this, as the session strategy does not seem to be pluggable)

Shall I (try to) make a pull request?

Current workaround:

Comment the function \PHPUnit_Extensions_Selenium2TestCase_SessionStrategy_Shared::notSuccessfulTest

@amenk amenk changed the title Add FullyShared Session Strategy Add FullyShared Session Strategy (even in case of failures) May 6, 2016
@giorgiosironi
Copy link
Owner

Indeed, PR welcome. Ideally should make it pluggable by specifying a Strategy object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants