[GIN-001] - Add TOML bining for gin

[Valentine-Mario]

• With pull requests:
  • Open your pull request against master
  • Your pull request should have no more than two commits, if not you should squash them.
  • It should pass all tests in the available continuous integration systems such as GitHub Actions.
  • You should add/modify tests to cover your proposed code changes.
  • If your pull request contains a new feature, please document it on the README.

This PR aims to add a TOML binding to the gin framework

[Valentine-Mario]

@appleboy can you please help review

[efectn]

I think you should use v2 of github.com/pelletier/go-toml. It's more performant

[Valentine-Mario]

The v2 version is still in beta and might still have numerous bugs at the moment

[efectn]

The v2 version is still in beta and might still have numerous bugs at the moment

Hugo uses v2, also i think it doesn't have critical bugs.
gohugoio/hugo@a3701e0

[Valentine-Mario]

The v2 version is still in beta and might still have numerous bugs at the moment

Hugo uses v2, also i think it doesn't have critical bugs. gohugoio/hugo@a3701e0

The TOML parser has been updated to v2. Please review. Thanks

[efectn]

Looks good to me.

[Valentine-Mario]

@appleboy fixed issues with gofmt

[appleboy]

Wait for @thinkerou approval.

[thinkerou]

lgtm, but please wait unit test ok, thanks!

[Valentine-Mario]

Resolved merge conflict and updated toml binding to use the type any

cc @thinkerou @appleboy

[thinkerou]

@Valentine-Mario sorry, please fix conflicts again, thanks!

[Valentine-Mario]

@Valentine-Mario sorry, please fix conflicts again, thanks!

Resolved @thinkerou

[Valentine-Mario]

@thinkerou not sure why this test is failing, com planning about the TOML in the context being undefined

[efectn]

@thinkerou not sure why this test is failing, com planning about the TOML in the context being undefined

Check https://github.com/gin-gonic/gin/blob/master/binding/binding_nomsgpack.go

[codecov]

Codecov Report

Merging #3081 (447e325) into master (c458094) will decrease coverage by 0.55%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #3081      +/-   ##
==========================================
- Coverage   98.77%   98.21%   -0.56%     
==========================================
  Files          41       43       +2     
  Lines        3105     3141      +36     
==========================================
+ Hits         3067     3085      +18     
- Misses         26       44      +18     
  Partials       12       12              

Flag	Coverage Δ
go-1.14	98.21% <50.00%> (-0.56%)	⬇️
go-1.15	98.05% <50.00%> (-0.56%)	⬇️
go-1.16	98.05% <50.00%> (-0.54%)	⬇️
go-1.17	97.96% <50.00%> (-0.56%)	⬇️
go-1.18	97.96% <50.00%> (-0.56%)	⬇️
macos-latest	98.21% <50.00%> (-0.56%)	⬇️
nomsgpack	98.19% <47.05%> (-0.57%)	⬇️
ubuntu-latest	98.21% <50.00%> (-0.56%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
render/render.go	100.00% <ø> (ø)
render/toml.go	0.00% <0.00%> (ø)
context.go	96.74% <22.22%> (-1.17%)	⬇️
binding/binding.go	100.00% <100.00%> (ø)
binding/binding_nomsgpack.go	100.00% <100.00%> (ø)
binding/toml.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c458094...447e325. Read the comment docs.

[thinkerou]

please add copyright info, thanks!

[thinkerou]

please add copyright info, thanks!