From 77a8f5ea2173dc0682295d9e55916dce03e29139 Mon Sep 17 00:00:00 2001
From: zihengCat <zihenglv@gmail.com>
Date: Fri, 25 Jun 2021 14:40:30 +0800
Subject: [PATCH] improve sliceValidateError.Error performance using switch and
 strings.Builder

fix missing nil pointer check

use simpler switch case

add missing tests

use for-loop instead of range

add benchmark test codes
---
 binding/default_validator.go                | 24 +++++++++++++++------
 binding/default_validator_benchmark_test.go | 20 +++++++++++++++++
 binding/default_validator_test.go           | 20 +++++++++++++++++
 3 files changed, 58 insertions(+), 6 deletions(-)
 create mode 100644 binding/default_validator_benchmark_test.go

diff --git a/binding/default_validator.go b/binding/default_validator.go
index ee69329ecc..87fc4c665b 100644
--- a/binding/default_validator.go
+++ b/binding/default_validator.go
@@ -20,15 +20,27 @@ type defaultValidator struct {
 
 type sliceValidateError []error
 
+// Error concatenates all error elements in sliceValidateError into a single string separated by \n.
 func (err sliceValidateError) Error() string {
-	var errMsgs []string
-	for i, e := range err {
-		if e == nil {
-			continue
+	n := len(err)
+	switch n {
+	case 0:
+		return ""
+	default:
+		var b strings.Builder
+		if err[0] != nil {
+			fmt.Fprintf(&b, "[%d]: %s", 0, err[0].Error())
+		}
+		if n > 1 {
+			for i := 1; i < n; i++ {
+				if err[i] != nil {
+					b.WriteString("\n")
+					fmt.Fprintf(&b, "[%d]: %s", i, err[i].Error())
+				}
+			}
 		}
-		errMsgs = append(errMsgs, fmt.Sprintf("[%d]: %s", i, e.Error()))
+		return b.String()
 	}
-	return strings.Join(errMsgs, "\n")
 }
 
 var _ StructValidator = &defaultValidator{}
diff --git a/binding/default_validator_benchmark_test.go b/binding/default_validator_benchmark_test.go
new file mode 100644
index 0000000000..839cf710b5
--- /dev/null
+++ b/binding/default_validator_benchmark_test.go
@@ -0,0 +1,20 @@
+package binding
+
+import (
+	"errors"
+	"strconv"
+	"testing"
+)
+
+func BenchmarkSliceValidateError(b *testing.B) {
+	const size int = 100
+	for i := 0; i < b.N; i++ {
+		e := make(sliceValidateError, size)
+		for j := 0; j < size; j++ {
+			e[j] = errors.New(strconv.Itoa(j))
+		}
+		if len(e.Error()) == 0 {
+			b.Errorf("error")
+		}
+	}
+}
diff --git a/binding/default_validator_test.go b/binding/default_validator_test.go
index e9c6de447d..e9debe59bf 100644
--- a/binding/default_validator_test.go
+++ b/binding/default_validator_test.go
@@ -16,6 +16,26 @@ func TestSliceValidateError(t *testing.T) {
 		want string
 	}{
 		{"has nil elements", sliceValidateError{errors.New("test error"), nil}, "[0]: test error"},
+		{"has zero elements", sliceValidateError{}, ""},
+		{"has one element", sliceValidateError{errors.New("test one error")}, "[0]: test one error"},
+		{"has two elements",
+			sliceValidateError{
+				errors.New("first error"),
+				errors.New("second error"),
+			},
+			"[0]: first error\n[1]: second error",
+		},
+		{"has many elements",
+			sliceValidateError{
+				errors.New("first error"),
+				errors.New("second error"),
+				nil,
+				nil,
+				nil,
+				errors.New("last error"),
+			},
+			"[0]: first error\n[1]: second error\n[5]: last error",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {